Feat/view-all-routes #70
Conversation
- Adjust the zoom level when panning the map - Add event listener for routeSelectedFromModal event - Update the layout and styling of the component - Add a button to view all available routes - Add translations for search related texts
There was a problem hiding this comment.
this is looking really good! I have noted a couple behavioral changes I'd like to see before merging it in the PR. Also, here are a few things I noticed when playing around with the feature that should get fixed:
Add a title to the View All Routes modal
It should be called "All Routes", and that text should appear above the search bar.
The search bar doesn't seem to be working
| {$t('loading')}... | ||
| </div> | ||
| </div> | ||
| <LoadingSpinner /> |
There was a problem hiding this comment.
The search bar is working but before I PR, I also added search by rotueId, I think I will remove it from the search filter so we can search by short and long name and description only
src/routes/api/oba/routes/+server.js
Outdated
| // TODO: change this api after deployment of get all routes api | ||
| export async function GET() { | ||
| try { | ||
| const agenciesResponse = await oba.agenciesWithCoverage.list(); |
There was a problem hiding this comment.
it doesn't look like you're caching this data on the server side yet, right? This should be run once per app launch—and then cached in memory, instead of reloaded on every request.
| } | ||
|
|
||
| async function preloadRoutesData() { | ||
| if (!routesCache) { |
No description provided.